<AWT Dev> RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

[Baesken, Matthias]

Hello Sergey, sorry for coming back to this a bit late .

I could not re-create  this "The Internet" shellfolder so far  (are you aware of any good tools for this kind of action btw.) ?
I looked a bit  into the  attributes  of this  shellfolder ,   it looks  strange  that  it does not have the  ATTRIB_FOLDER,  on my test machine all the other shellfolders I trace in  Win32ShellFolder2  have "ATTRIB_FOLDER"  set .

display name:The Internet
isDirectoryWithTrace - executing check
-------------------------------------------------
NO attribute ATTRIB_FOLDER found           <--- looks suspicious to me
NO attribute ATTRIB_CANCOPY found
NO attribute ATTRIB_CANMOVE found
 attribute ATTRIB_CANLINK found
 attribute ATTRIB_CANRENAME found
 attribute ATTRIB_CANDELETE found
 attribute ATTRIB_HASPROPSHEET found
NO attribute ATTRIB_DROPTARGET found
NO attribute ATTRIB_LINK found
NO attribute ATTRIB_SHARE found
NO attribute ATTRIB_READONLY found
NO attribute ATTRIB_GHOSTED found
NO attribute ATTRIB_HIDDEN found
NO attribute ATTRIB_FILESYSANCESTOR found
NO attribute ATTRIB_FILESYSTEM found
NO attribute ATTRIB_HASSUBFOLDER found
NO attribute ATTRIB_VALIDATE found
NO attribute ATTRIB_REMOVABLE found
NO attribute ATTRIB_COMPRESSED found
 attribute ATTRIB_BROWSABLE found
 attribute ATTRIB_NONENUMERATED found
NO attribute ATTRIB_NEWCONTENT found

Additonally the  isLink()   call  in  Win32ShellFolder2.java   for this shellfolder returns false .


Is there already  a place in the jdk coding  to filter out  such shellfolders ?

Best regards, Matthias



> -----Original Message-----
> From: Baesken, Matthias
> Sent: Dienstag, 5. November 2019 18:02
> To: 'Sergey Bylokhov' <Sergey.Bylokhov at oracle.com>; awt-
> dev at openjdk.java.net
> Subject: RE: <AWT Dev> RFR: 8227257:
> javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError
> 
> Hi  Sergey, I do not create this shellfolder "link", so I have to look into it or
> find out who creates it (and how ).
> 
> Best regards, Matthias
> 
> >
> > Hi, Matthias.
> >
> > On 10/22/19 1:06 am, Baesken, Matthias wrote:
> > > It is the combination of running  the tests with  ea/esa  AND   our strange
> > setup  ;
> > >   the assertion occurred when handling in the isDirectory - method of
> > Win32ShellFolder2 a  ShellFolder with display name "The Internet" which
> has
> > attribute ATTRIB_BROWSABLE but not ATTRIB_FOLDER set.
> >
> > Do you know the steps on how to create such "The Internet" link?
> >
> > >
> > >
> > > And  I am not  even 100% sure that the assertion we see  is correct in this
> > case.
> > >