<AWT Dev> [14] RFR JDK-8225805 - Java Access Bridge does not close the logger

Dmitry Markov dmitry.markov at oracle.com
Tue Sep 10 11:24:22 UTC 2019


Hi Pankaj,

The fix looks good to me.

Thanks,
Dmitry

> On 10 Sep 2019, at 11:06, Pankaj Bansal <pankaj.b.bansal at oracle.com> wrote:
> 
> Hi All,
> 
> Please review the following fix for jdk14.
> 
> Bug: 
> https://bugs.openjdk.java.net/browse/JDK-8225805 <https://bugs.openjdk.java.net/browse/JDK-8225805>
>  
> webrev
> http://cr.openjdk.java.net/~pbansal/8225805/webrev01/ <http://cr.openjdk.java.net/~pbansal/8225805/webrev01/>
>  
>  
> Issue:
> The Windows WindowsAccessBridge Log file is not being closed anywhere. We should always close opened resources.
> It is not causing any issue as all files opened by the program are closed when program exits normally (JAWS in this case). But case be an issue in case the program terminates abnormally. We should explicitly close the log file.
>  
> Fix:
> Closed the WindowsAccessBridge log file in destructor.
>  
> 
> Regards,
> Pankaj Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190910/f68d236b/attachment.html>


More information about the awt-dev mailing list