<AWT Dev> <Awt Dev> [13] RFR [JDK-8080185][TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

[Jagjot Singh]

Hi Sergey,

I went through JDK-6242241. The regression test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor was written to cover the issue encountered in JDK-6242241. Previous version of MS Outlook does not provide DataFlavor.javaFileListFlavor. Starting from MS Outlook Express 6, MS Outlook provides DataFlavor.javaFileListFlavor. Hence, the test was passing and the issue was not reproducible.

Dragging and Dropping a file from any location (e.g. Windows Explorer) apart from MS Outlook was never a problem. Adding them to the instruction set will not lead to the failure of the test.  According to the issue with which the test was written, the current changes proposed to be done in the instruction set may seem inappropriate. But, this issue is no more reproducible with version of Outlook starting from Express 6 and current changes will increase the coverage of the test.  Sergey, what are your thoughts on it?

My bad with the JDK version. The fix is for jdk14 not jdk13.

Best Regards,
Jagjot Singh

-----Original Message-----
From: Sergey Bylokhov 
Sent: Monday, September 16, 2019 11:44 PM
To: Jagjot Singh <jagjot.singh at oracle.com>; awt-dev at openjdk.java.net
Cc: Praveen Mohan <praveen.mohan at oracle.com>; Gauri Patil <gauri.patil at oracle.com>; Praveen Gupta <praveen.p.gupta at oracle.com>
Subject: Re: <AWT Dev> <Awt Dev> [13] RFR [JDK-8080185][TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

Hi, Jagjot.

Did you check that an initial bug JDK-6242241 can be reproduced by the new instructions?
I assume the fix is for jdk14 not jdk13.

On 9/13/19 3:21 am, Jagjot Singh wrote:
> Hi All,
> 
> Please review a small fix for JDK-8080185
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8080185
> 
> Webrev:http://cr.openjdk.java.net/~vagarwal/8080185/webrev.0/
> 
> Summary: The regression test  java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor needs further addition to the instruction set. The instructions suggests that we need to select an attachment from MS Outlook and drag and drop into the red field of applet . It is not mandatory. We can even drag and drop any file from any location into the red field of applet. File path appears in both cases. Updating the test instructions accordingly.
> 
> Best Regards,
> 
> Jagjot Singh
> 


-- 
Best regards, Sergey.