<AWT Dev> RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

Phil Race prr at openjdk.java.net
Wed Dec 16 19:17:03 UTC 2020


On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved the new components implementations to the separate files.
>   Changed the iitialization procedure to a class function with
>   dictionary of role to class name relation.
>   
>   This pr is still intermittent since it uses the old style
>   JNF java call syntacsis. Once fix for JDK-8257853 is integrated
>   the calls needs to be converted to the new style but that is a minor
>   change.

All looks fine to me, although it will hit the changes to remove JNF for JNI calls in a head-on conflict.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1549


More information about the awt-dev mailing list