<AWT Dev> RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v6]
Gerard Ziemski
gziemski at openjdk.java.net
Fri Dec 18 16:03:58 UTC 2020
On Fri, 18 Dec 2020 11:20:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
>
> I believe we could add CHECK_EXCEPTION in few places...pointing those out...
There seems to be a pattern where we replace `JNFCallObjectMethod()` with a pair of `CallObjectMethod()` immediately followed by `CHECK_EXCEPTION()`
There are places where currently in this fix, this pattern is missing the `CHECK_EXCEPTION()`
Can we replace `JNFCallObjectMethod()` by a single function call (or macro) that wraps both `CallObjectMethod()` and `CHECK_EXCEPTION()` into one?
This would make this change more robust and make it easier to review it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1679
More information about the awt-dev
mailing list