<AWT Dev> RFR: 8176040 Documentation of java.awt.Rectangle.add(java.awt.Point) is wrong.

Phil Race philip.race at oracle.com
Tue Mar 3 21:33:17 UTC 2020


Ok.

-phil

On 3/2/20 10:57 AM, Alexander Zuev wrote:
> I guess you mean add(new Rectangle(pt, new Dimension(1, 1))); which is 
> not that elegant but as we got Point as parameter
> we might as well use constructor with Point as well.
>
> New fix available here: 
> http://cr.openjdk.java.net/~kizune/8176040/webrev.01
>
> /Alex
>
> On 3/2/20 21:33, Philip Race wrote:
>> Or add(p, new Dimension(1,1));
>>
>> which might be a better option in the 2nd case.
>>
>> -phil.
>>
>> On 3/2/20, 10:21 AM, Sergey Bylokhov wrote:
>>> Looks fine.
>>>
>>> On 3/2/20 10:11 am, Alexander Zuev wrote:
>>>> Hello!
>>>>
>>>>    Please review fix for the jdk/client.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8176040
>>>> Fix: http://cr.openjdk.java.net/~kizune/8176040/webrev 
>>>> <http://cr.openjdk.java.net/~kizune/8176040/webrev/>
>>>>
>>>> Fix is trivial, i just changed the JavaDoc of two methods of 
>>>> java.awt.Rectangle that previously referenced
>>>> non-existing method of the same class. One day it had to be done i 
>>>> guess.
>>>>
>>>> /Alex
>>>
>>>
>



More information about the awt-dev mailing list