<AWT Dev> RFR: 8231231: The printing result is different from the case instruction

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Oct 21 11:56:21 UTC 2020


Please review a manual printing test failure where the instructions is not matching the printing result 
as the labels which are present in the test instruction frame is cut off in printed result due to margin not being accounted for, 
as the labels in the test instruction is fully left aligned starting from 0.
Fixed by adding some spaces before labels and 
for other labels drawn through drawChars, modified to draw the labels from coordinate 20 instead of 0 to allow labels being printed in the paper and not get cutoff by margin.
Also, the Print instruction is brought to top and 1st label is brought to bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to account for top margin cutoff, brought it lower so that those labels does not get cut off.

-------------

Commit messages:
 - 8231231: The printing result is different from the case instruction

Changes: https://git.openjdk.java.net/jdk/pull/780/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=780&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8231231
  Stats: 13 lines in 1 file changed: 1 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/780.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/780/head:pull/780

PR: https://git.openjdk.java.net/jdk/pull/780


More information about the awt-dev mailing list