<AWT Dev> RFR: 8242559: Clean the "libawt_xawt" library from code for headless mode

Phil Race prr at openjdk.java.net
Sun Sep 13 04:24:28 UTC 2020


On Wed, 9 Sep 2020 23:20:07 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> This bug extracted from JDK-8240290[1]
> 
> The libawt_xawt.so library is used by the headful toolkit, but it still
> has some code related to the headless mode, which could be deleted.
> 
> In the fix, the HEADLESS related code was removed, to prove that we did
> not build this library in HEADLESS mode, I added "#error This " to all
> library files(but some of them already has it)
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8240290
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-April/015881.html

Clearly these are there to prevent mistakes. So they add value at a tiny build time cost.
I don't see the point of removing them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/101


More information about the awt-dev mailing list