<AWT Dev> RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209) [v2]

[Hohensee, Paul]

Hmm. I'm running Xcode 12.0.1 on 10.15.6 and don't see it. Are you sure you have the '&' in front of locs_buf? I.e.,

      buffer.insts()->initialize_shared_locs((relocInfo*)&locs_buf, sizeof(locs_buf) / sizeof(relocInfo));
                                                                                             ^
Thanks,
Paul

On 9/29/20, 1:07 PM, "build-dev on behalf of Lutz Schmidt" <build-dev-retn at openjdk.java.net on behalf of lucy at openjdk.java.net> wrote:

    On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

    >> Please review this small patch to enable the OSX build using Xcode 12.0.
    >>
    >> Thanks,
    >> Paul
    >
    > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
    > excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since
    > the last revision:
    >  - 8253375: Reverted CSystemColors.m patch, replaced sharedRuntime.cpp patch
    >  - Merge branch 'master' into JDK-8253375
    >  - JDK-8253375

    The proposed (updated) change does _NOT_ compile on my machine (MacOS 10.15.6, Xcode 12.0):

    sharedRuntime.cpp:2860:46: error: cannot cast from type 'struct (anonymous struct at sharedRuntime.cpp:2859:7)' to
    pointer type 'relocInfo *'

    You will have to use a union (option (2) as proposed by Kim Barrett far above. I proved that variant compiles on my
    machine.

    -------------

    Changes requested by lucy (Reviewer).

    PR: https://git.openjdk.java.net/jdk/pull/348