<AWT Dev> RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]
Andrey Turbanov
github.com+741251+turbanoff at openjdk.java.net
Thu Apr 8 14:43:52 UTC 2021
On Wed, 7 Apr 2021 15:21:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> [PATCH] Replace uses of StringBuffer with StringBuilder in java.desktop
>>
>> fix copyright year
>
> src/java.desktop/unix/classes/sun/awt/X11/XCreateWindowParams.java line 88:
>
>> 86: while (eIter.hasNext()) {
>> 87: Map.Entry<Object, Object> entry = eIter.next();
>> 88: buf.append(entry.getKey()).append(": ").append(entry.getValue()).append("\n");
>
> Would it be clearer if each append was on its own line?
> Suggestion:
>
> buf.append(entry.getKey())
> .append(": ")
> .append(entry.getValue())
> .append("\n");
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/3251
More information about the awt-dev
mailing list