<AWT Dev> RFR: 8182043: Access to Windows Large Icons [v3]

[Alexey Ivanov]

On Fri, 30 Apr 2021 12:27:19 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>   
>   Select one icon at a time.
>   
>   Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 267:

> 265:     * returned will be a multi-resolution icon image,
> 266:     * which will allow better scaling with different
> 267:     * magnification factors.

I'm not sure what are the standard terms to refer to High DPI environments and the scale factors associated with High DPI.

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 275:

> 273:     * </pre>
> 274:     *
> 275:     * @param f a <code>File</code> object

Suggestion:

    * @param f a {@code File} object

src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java line 213:

> 211:      * Returns the icon of the specified size used to display this shell folder.
> 212:      *
> 213:      * @param size size of the icon > 0 (Valid range: 1 to 256)

I'm unsure the valid range of 1 to 256 makes sense provided the icon smaller than 16×16 is never returned (on Windows at least).

src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1193:

> 1191:     static Image getShell32Icon(int iconID, int size) {
> 1192:         Toolkit toolkit = Toolkit.getDefaultToolkit();
> 1193:         String shellIconBPP = (String)toolkit.getDesktopProperty("win.icon.shellIconBPP");

Looks like these lines aren't used any more and should be removed too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875