<AWT Dev> RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module [v2]
Sergey Bylokhov
serb at openjdk.java.net
Tue Aug 3 21:42:33 UTC 2021
On Tue, 3 Aug 2021 21:18:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8271456
>> - Initial fix for JDK-8271456
>
> src/java.desktop/windows/classes/sun/awt/windows/WDataTransferer.java line 270:
>
>> 268: charset = new String((byte[])localeTransferable.
>> 269: getTransferData(javaTextEncodingFlavor),
>> 270: StandardCharsets.UTF_8);
>
> Suggestion:
>
> getTransferData(javaTextEncodingFlavor),
> StandardCharsets.UTF_8);
>
> The parameter on the second line should probably be aligned with the first parameter as it's done in the snippet above.
it is aligned already, the StandardCharsets.UTF_8 is parameter of "new String()", not the getTransferData.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4951
More information about the awt-dev
mailing list