<AWT Dev> RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Aug 4 05:09:30 UTC 2021


On Tue, 3 Aug 2021 18:30:09 GMT, rajat mahajan <github.com+79671271+rajamah at openjdk.org> wrote:

>> test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java line 54:
>> 
>>> 52: public class ButtonGroupLayoutTraversalTest {
>>> 53: 
>>> 54:     private static final int nx = 3;
>> 
>> Normally, as per coding standard, for static final modifier, the variable should be named in CAPS...but is there any need of making it final?
>
> @prsadhuk I did what you asked, do you have any more questions or comments ?, if not could you please approve this PR, thanks.

I still think nx, ny should be made CAPS...It seems to be the case for static final constant variables in java/awt test folder...I don't think it will increase noise as it will impact only in l57

-------------

PR: https://git.openjdk.java.net/jdk/pull/4937


More information about the awt-dev mailing list