<AWT Dev> RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v4]

lawrence.andrews github.com+87324768+lawrence-andrew at openjdk.java.net
Wed Aug 11 16:56:28 UTC 2021


On Wed, 11 Aug 2021 16:33:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rewrote the code for better starting the test and timeout
>
> test/jdk/java/awt/print/PrinterJob/XparColor.java line 122:
> 
>> 120: 
>> 121:     private static void createAndShowTestDialog() {
>> 122:         String testInstruction = "This testcase will be launched twice, once for opengl and once for metal.\n" +
> 
> The test is supposed to be run in all platforms, not only in mac. Since the default pipeline is not opengl in non-mac platform and also metal is not supported in non-mac platform, so this test instruction that it will run in opengl and metal is wrong in non-mac platform. 
> You probably need to modify to say it will be run in default pipeline for a particular platform and metal and subsequently check if the platform is non-mac and bail out if metal=true system property is set and inform user that metal cannot be run in present non-mac platform

Thanks @prsadhuk, will modify the instruction

-------------

PR: https://git.openjdk.java.net/jdk/pull/4769


More information about the awt-dev mailing list