<AWT Dev> RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v2]

rajat mahajan github.com+79671271+rajamah at openjdk.java.net
Sat Aug 14 01:15:49 UTC 2021


On Fri, 13 Aug 2021 19:38:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> rajat mahajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix IDE warnings, added Default Locale as US, fixed Copyright to include current year.
>
> test/jdk/java/awt/print/PrinterJob/PageDialogMarginTest.java line 58:
> 
>> 56:         HashPrintRequestAttributeSet aset = new HashPrintRequestAttributeSet();
>> 57:         PageFormat pf;
>> 58:         pf = pj.pageDialog(aset);
> 
> I suggest merging these two lines:
> Suggestion:
> 
>         PageFormat pf = pj.pageDialog(aset);

Made the changes you asked.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5115


More information about the awt-dev mailing list