<AWT Dev> RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
Phil Race
prr at openjdk.java.net
Thu Aug 19 20:28:26 UTC 2021
On Wed, 18 Aug 2021 23:57:38 GMT, Phil Race <prr at openjdk.org> wrote:
> When Ctrl+Space is pressed mac generates a string that contains the single unicode code point zero.
> The fn that converts it from an NSString to a Java String is using NewStringUTF.
> The input to that is a null terminated string which also has zero as the code point it contains, so
> we actually end up with a zero length Java string instead of the intended one code point in length.
> So the fix is to change the way we convert the string.
>
> There's an existing test CtrlAscii.java which sort of tests some of this but it isn't asserting that you
> get what you expect, its mostly testing you don't get something *unexpected* .. it will happily pass if
> you don't get keyevents. I did not want to change the purpose of that test for this.
> So I wrote a test specific to this Ctrl+Space to verify the fix but also ran all the standard automated tests too.
Yep, it is unrelated to what is being touched in this fix so should be handled separately.
It needs a new bug report and this fix can go ahead.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5177
More information about the awt-dev
mailing list