<AWT Dev> RFR: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails [v3]

Alexey Ushakov avu at openjdk.java.net
Wed Aug 25 17:32:47 UTC 2021


On Tue, 24 Aug 2021 23:56:54 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
>>   
>>   Moved peer.setTextured() to the place where windowLayer is initialized
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 339:
> 
>> 337:         if (peer != null) { // Not applicable to CWarningWindow
>> 338:             peer.setTextured(IS(TEXTURED, styleBits));
>> 339:         }
> 
> This probably works fine, but maybe we can move it after "setPtr(ref.get());" below? or that ptr is not used in this new call chain?

Yes, it does work. But it's a good idea to move the code here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5172


More information about the awt-dev mailing list