<AWT Dev> RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v2]

[Alexander Zuev]

On Thu, 17 Dec 2020 08:18:26 GMT, Pankaj Bansal <pbansal at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved the new components implementations to the separate files.
>>   Changed the iitialization procedure to a class function with
>>   dictionary of role to class name relation.
>>   
>>   This pr is still intermittent since it uses the old style
>>   JNF java call syntacsis. Once fix for JDK-8257853 is integrated
>>   the calls needs to be converted to the new style but that is a minor
>>   change.
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ButtonAccessibility.h line 25:
> 
>> 23:  * questions.
>> 24:  */
>> 25: 
> 
> There are no header guard here. Is it left intentionally?

Yes, since the CommonComponentAccessibility being imported from the base class sometimes it causes compilation glitches - guess ObjC is not a big fan of forward-declaration. Adding header guard helps. And since i'm not planning to include sub-component header files in the base classes the ifdef guard is not required.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1549