<AWT Dev> RFR: 8256109: Create implementation for NSAccessibilityButton protocol [v5]
Alexander Zuev
kizune at openjdk.java.net
Thu Jan 14 04:54:18 UTC 2021
On Thu, 14 Jan 2021 00:17:57 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Replaced #include with #import for consistency
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m line 61:
>
>> 59: {
>> 60: if (rolesMap == nil) {
>> 61: [self initializeRolesMap];
>
> Is it possible that this will be called on the different threads? Or it is always appkit(probably AWT_ASSERT_APPKIT_THREAD could be useful)?
Well, this method is being called from AppKit thread only but giving that it is static and public adding an assertion would be indeed wise. Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1549
More information about the awt-dev
mailing list