<AWT Dev> RFR: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test [v4]

Alexey Ivanov aivanov at openjdk.java.net
Fri Jan 29 20:22:47 UTC 2021


On Fri, 29 Jan 2021 18:05:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> This test was failing in our nightly mach5 testing. Appropriate stability code in form of waitForIdle and delay is added.
>> mach5 job running for several iterations on all platforms is ok. Link in JBS.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Declare m_breakMessageLoop volatile

src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h line 478:

> 476:     BOOL m_breakOnError;
> 477: 
> 478:     volatile BOOL  m_breakMessageLoop;

Does this volatile modifier resolve the now-removed infinite loop in `while (!tk.IsDisposed())` in `WToolkit_shutdown`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2220


More information about the awt-dev mailing list