<AWT Dev> RFR: 8267307: Introduce new client property for XAWT: xawt.mwm_decor_title [v2]

Maxim Kartashev github.com+28651297+mkartashev at openjdk.java.net
Fri Jun 4 08:44:23 UTC 2021


On Fri, 4 Jun 2021 06:49:13 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed the check for the XFramePeer target being javax.swing.RootPaneContainer in
>>   order to avoid unnecessary class loading if it isn't.
>>   
>>   Also updated the test such that robot.createScreenCapture() is not
>>   executed on EDT.
>
> src/java.desktop/unix/classes/sun/awt/X11/XFramePeer.java line 84:
> 
>> 82: 
>> 83:     private void registerWindowDecorationChangeListener() {
>> 84:         if (target instanceof javax.swing.RootPaneContainer) {
> 
> Probably this should be done via runtime check? Overwise the swing classes will be always loaded even if swing is not used. see the usage of SunToolkit.isInstanceOf in java.awt.WIndow.java:3965

Thanks! Updated the code; please, have a look.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4113


More information about the awt-dev mailing list