From github.com+741251+turbanoff at openjdk.java.net Wed Sep 1 10:44:07 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 1 Sep 2021 10:44:07 GMT Subject: RFR: 8273168: Remove superfluous use of boxing in java.desktop [v2] In-Reply-To: References: Message-ID: > parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as they return primitives. While valueOf returns boxed object. Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into redundant_boxing_in_java.desktop - [PATCH] Cleanup redundant boxing in java.desktop module parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as they return primitives. While valueOf returns boxed object. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/5313/files - new: https://git.openjdk.java.net/jdk/pull/5313/files/c24b15a5..a6bdbb7d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5313&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5313&range=00-01 Stats: 995 lines in 34 files changed: 688 ins; 181 del; 126 mod Patch: https://git.openjdk.java.net/jdk/pull/5313.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5313/head:pull/5313 PR: https://git.openjdk.java.net/jdk/pull/5313 From github.com+741251+turbanoff at openjdk.java.net Wed Sep 1 19:30:11 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 1 Sep 2021 19:30:11 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v4] In-Reply-To: References: Message-ID: On Fri, 27 Aug 2021 18:28:58 GMT, Sergey Bylokhov wrote: >> Can you please elaborate? >> As I can see if size of array is exactly the same as size of vector/arraylist, implementations are similar - they just call System.arraycopy >> ![???????????](https://user-images.githubusercontent.com/741251/131168809-480c05d6-2775-4812-91f5-c73833f9a396.png) > > To confirm this you need to do the same check on every usage of added toArray([]), the simpler version like "return toArray()" or return toArray(new MenuElement[elements.size()]) is simpler, no need to check something. I guess in some previouse fixes it was confirmed that the "return toArray(new MenuElement[0])" is even faster. Ok. Simplified ------------- PR: https://git.openjdk.java.net/jdk/pull/4680 From github.com+741251+turbanoff at openjdk.java.net Wed Sep 1 19:30:10 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 1 Sep 2021 19:30:10 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v5] In-Reply-To: References: Message-ID: <2uvW-RV4K6LMrM5QpOJF2v_FjDJVZpkj1746Q_GAY9A=.b94c87be-ebd8-4ea8-aede-cf84126a6290@github.com> > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checked only places where `Vector` was used as local variable. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8271603: Unnecessary Vector usage in java.desktop use toArray with zero sized array in places where Vector.copyInto was used ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4680/files - new: https://git.openjdk.java.net/jdk/pull/4680/files/5727f6f2..1f0ebd1c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=03-04 Stats: 22 lines in 9 files changed: 0 ins; 13 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/4680.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680 PR: https://git.openjdk.java.net/jdk/pull/4680 From github.com+741251+turbanoff at openjdk.java.net Wed Sep 1 19:46:51 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 1 Sep 2021 19:46:51 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v6] In-Reply-To: References: Message-ID: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com> > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checked only places where `Vector` was used as local variable. Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop # Conflicts: # src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java - 8271603: Unnecessary Vector usage in java.desktop use toArray with zero sized array in places where Vector.copyInto was used - 8271603: Unnecessary Vector usage in java.desktop migrate even more usages - 8271603: Unnecessary Vector usage in java.desktop migrate more usages. Not sure how I missed them - 8271603: Unnecessary Vector usage in java.desktop revert back to use cycle to copy into array - 8271603: Unnecessary Vector usage in java.desktop revert back to Enumeration bring back default values - [PATCH] Unnecessary Vector usage in java.desktop use zero-length array - [PATCH] Unnecessary Vector usage in java.desktop ------------- Changes: https://git.openjdk.java.net/jdk/pull/4680/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=05 Stats: 270 lines in 34 files changed: 19 ins; 30 del; 221 mod Patch: https://git.openjdk.java.net/jdk/pull/4680.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680 PR: https://git.openjdk.java.net/jdk/pull/4680 From philip.race at oracle.com Wed Sep 1 22:04:23 2021 From: philip.race at oracle.com (Philip Race) Date: Wed, 1 Sep 2021 15:04:23 -0700 Subject: Fwd: Project Wakefield announcement and welcome In-Reply-To: <09dddbdd-d4d2-c6f4-1622-583239d91e4a@oracle.com> References: <09dddbdd-d4d2-c6f4-1622-583239d91e4a@oracle.com> Message-ID: FYI -------- Forwarded Message -------- Subject: Project Wakefield announcement and welcome Date: Wed, 1 Sep 2021 14:59:30 -0700 From: Philip Race To: wakefield-dev at openjdk.java.net Hi all, The project has been recorded in the OpenJDK census : https://openjdk.java.net/census#wakefield The email list (to which I sent this) https://mail.openjdk.java.net/mailman/listinfo/wakefield-dev has been set up pre-populated with the initial committers. If you are a committer who did not previously have an OpenJDK ID you should have received an invitation to register. Don't ignore it - it will expire in 14 days from when it was sent. We also have a web page https://openjdk.java.net/projects/wakefield/ which is still just pro-forma I'll add something more once we have it :-) The wiki is also being set up : https://wiki.openjdk.java.net/display/wakefield Unlike the Project Page everyone who is a committer will be able to edit the wiki The project repo has not yet been created but is expected to be created this week. I will send a follow up on that once it is done. I'll also inform the various client lists (forward please do NOT cross post !)? of the new mailing list -phil. -------------- next part -------------- An HTML attachment was scrubbed... URL: From serb at openjdk.java.net Thu Sep 2 08:20:53 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 2 Sep 2021 08:20:53 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging Message-ID: The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. This is the request to delete the usage of AppContext in the LogManager and related tests. Tested by tier1/tier2/tier3 and jdk_desktop tests. ------------- Commit messages: - Some tests deleted - Update the RootLevelInConfigFile test - Initial version of JDK-8273101 Changes: https://git.openjdk.java.net/jdk/pull/5326/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5326&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273101 Stats: 1423 lines in 10 files changed: 0 ins; 1418 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/5326.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5326/head:pull/5326 PR: https://git.openjdk.java.net/jdk/pull/5326 From serb at openjdk.java.net Fri Sep 3 03:20:38 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 3 Sep 2021 03:20:38 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v6] In-Reply-To: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com> References: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com> Message-ID: On Wed, 1 Sep 2021 19:46:51 GMT, Andrey Turbanov wrote: >> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. >> I checked only places where `Vector` was used as local variable. > > Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: > > - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop > > # Conflicts: > # src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java > - 8271603: Unnecessary Vector usage in java.desktop > use toArray with zero sized array in places where Vector.copyInto was used > - 8271603: Unnecessary Vector usage in java.desktop > migrate even more usages > - 8271603: Unnecessary Vector usage in java.desktop > migrate more usages. Not sure how I missed them > - 8271603: Unnecessary Vector usage in java.desktop > revert back to use cycle to copy into array > - 8271603: Unnecessary Vector usage in java.desktop > revert back to Enumeration > bring back default values > - [PATCH] Unnecessary Vector usage in java.desktop > use zero-length array > - [PATCH] Unnecessary Vector usage in java.desktop src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1578: > 1576: } > 1577: String[] retValue = new String[temp.size()]; > 1578: temp.toArray(retValue); Why not `return temp.toArray(new String[0]);` like in other places in the last commit? ------------- PR: https://git.openjdk.java.net/jdk/pull/4680 From github.com+741251+turbanoff at openjdk.java.net Fri Sep 3 08:05:00 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Fri, 3 Sep 2021 08:05:00 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v6] In-Reply-To: References: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com> Message-ID: On Fri, 3 Sep 2021 03:17:02 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: >> >> - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop >> >> # Conflicts: >> # src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java >> - 8271603: Unnecessary Vector usage in java.desktop >> use toArray with zero sized array in places where Vector.copyInto was used >> - 8271603: Unnecessary Vector usage in java.desktop >> migrate even more usages >> - 8271603: Unnecessary Vector usage in java.desktop >> migrate more usages. Not sure how I missed them >> - 8271603: Unnecessary Vector usage in java.desktop >> revert back to use cycle to copy into array >> - 8271603: Unnecessary Vector usage in java.desktop >> revert back to Enumeration >> bring back default values >> - [PATCH] Unnecessary Vector usage in java.desktop >> use zero-length array >> - [PATCH] Unnecessary Vector usage in java.desktop > > src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1578: > >> 1576: } >> 1577: String[] retValue = new String[temp.size()]; >> 1578: temp.toArray(retValue); > > Why not `return temp.toArray(new String[0]);` like in other places in the last commit? Good catch! Update here too. ------------- PR: https://git.openjdk.java.net/jdk/pull/4680 From github.com+741251+turbanoff at openjdk.java.net Fri Sep 3 08:04:52 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Fri, 3 Sep 2021 08:04:52 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v7] In-Reply-To: References: Message-ID: > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checked only places where `Vector` was used as local variable. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8271603: Unnecessary Vector usage in java.desktop one more place to call toArray with zero-sized array ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4680/files - new: https://git.openjdk.java.net/jdk/pull/4680/files/2fb05a2c..f0ab7f17 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=06 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=05-06 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4680.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680 PR: https://git.openjdk.java.net/jdk/pull/4680 From prr at openjdk.java.net Fri Sep 3 16:18:24 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 3 Sep 2021 16:18:24 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. This fix requires coordinated closed changes so needs an Oracle sponsor. And actually is probably better handled entirely by an Oracle engineer because pushes need to be very co-ordinated. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From prr at openjdk.java.net Fri Sep 3 16:53:28 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 3 Sep 2021 16:53:28 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. I believe we should have a CSR for this. It removes a long standing capability in the platform that was used by components such as plugin and webstart. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From prr at openjdk.java.net Fri Sep 3 17:22:27 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 3 Sep 2021 17:22:27 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. Hmm I was under the impression this was removing AppContext itself but it is just removing the backdoor needed by logging Perhaps this isn't the change that requires the CSR but it then leaves an inconsistent state where desktop supports AppContext still but other modules don't ... ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From prr at openjdk.java.net Fri Sep 3 17:33:24 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 3 Sep 2021 17:33:24 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: <6GaYNpoX8_A1olW1Ikfu03HdbhVbK7reFN0BdTnV77w=.1aecd2fc-ace8-4f91-9a2c-a08b05086fc0@github.com> On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. @aivanov-jdk will help make sure the closed changes are pushed at exactly the same time as this gets pushed. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From serb at openjdk.java.net Fri Sep 3 17:46:27 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 3 Sep 2021 17:46:27 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Fri, 3 Sep 2021 17:19:05 GMT, Phil Race wrote: > Perhaps this isn't the change that requires the CSR but it then leaves an inconsistent state where desktop supports AppContext still but other modules don't ... Even java.desktop does not support it fully, since for a couple of years nobody care about appcontext when write a new code. Note that I mentioned the "threadgroup sandboxing" in the subject, which is not necessary implemented via Appcontext. The JavaBeans and JavaSound use the thread group directly, I plan to remove them as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From dfuchs at openjdk.java.net Fri Sep 3 20:30:12 2021 From: dfuchs at openjdk.java.net (Daniel Fuchs) Date: Fri, 3 Sep 2021 20:30:12 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: <6tT-CF3Huqab-wBF2L_yzvaCw23pML3Oc2jFALEhWew=.306be274-9244-4050-b9be-d12542123c68@github.com> On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. Right. I am also a bit uncomfortable about the inconsistency. That said - if everybody agrees that this should be done I have no objection. The changes to the java.util.logging implementation correspond to my expectation if this were to be carried through. test/jdk/java/util/logging/TestLoggingWithMainAppContext.java line 1: > 1: /* Humm... There's no direct reference to AppContext here. Maybe this test should be preserved? ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From serb at openjdk.java.net Fri Sep 3 22:17:56 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 3 Sep 2021 22:17:56 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: <6tT-CF3Huqab-wBF2L_yzvaCw23pML3Oc2jFALEhWew=.306be274-9244-4050-b9be-d12542123c68@github.com> References: <6tT-CF3Huqab-wBF2L_yzvaCw23pML3Oc2jFALEhWew=.306be274-9244-4050-b9be-d12542123c68@github.com> Message-ID: On Thu, 2 Sep 2021 09:59:51 GMT, Daniel Fuchs wrote: >> The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. >> >> This is the request to delete the usage of AppContext in the LogManager and related tests. >> >> Tested by tier1/tier2/tier3 and jdk_desktop tests. > > test/jdk/java/util/logging/TestLoggingWithMainAppContext.java line 1: > >> 1: /* > > Humm... There's no direct reference to AppContext here. Maybe this test should be preserved? It uses it indirectly, the next line under security manager trigger creation of the appcontext: `ImageIO.read(is); // triggers calls to system loggers & creation of main AppContext` but I can preserve/rename it for sure. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From serb at openjdk.java.net Sat Sep 4 00:40:54 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 4 Sep 2021 00:40:54 GMT Subject: RFR: 8271603: Unnecessary Vector usage in java.desktop [v7] In-Reply-To: References: Message-ID: On Fri, 3 Sep 2021 08:04:52 GMT, Andrey Turbanov wrote: >> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. >> I checked only places where `Vector` was used as local variable. > > Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: > > 8271603: Unnecessary Vector usage in java.desktop > one more place to call toArray with zero-sized array Marked as reviewed by serb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4680 From avu at openjdk.java.net Sat Sep 4 20:02:59 2021 From: avu at openjdk.java.net (Alexey Ushakov) Date: Sat, 4 Sep 2021 20:02:59 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 Message-ID: Used setOpaque() method to set correct background of platform window ------------- Commit messages: - 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 Changes: https://git.openjdk.java.net/jdk/pull/5373/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5373&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273355 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/5373.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5373/head:pull/5373 PR: https://git.openjdk.java.net/jdk/pull/5373 From prr at openjdk.java.net Sat Sep 4 21:24:51 2021 From: prr at openjdk.java.net (Phil Race) Date: Sat, 4 Sep 2021 21:24:51 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 19:54:55 GMT, Alexey Ushakov wrote: > Used setOpaque() method to set correct background of platform window src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java line 295: > 293: // Set correct background for a window before making it visible > 294: platformWindow.setOpaque(!isTranslucent()); > 295: } This looks as if it will affect OpenGL as well as Metal. Do you see the flckering with both pipelines ? What testing have you done with both of them ? ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From serb at openjdk.java.net Sat Sep 4 21:38:55 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 4 Sep 2021 21:38:55 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 19:54:55 GMT, Alexey Ushakov wrote: > Used setOpaque() method to set correct background of platform window Calling "platformWindow.setOpaque(!isTranslucent());" is equvivalent of calling these three methods: setOpaque(getTarget().isOpaque()); applyShape(Region.getInstance(shape, null)); peer.setTextured(IS(TEXTURED, styleBits)); All of them are executed before "platformWindow.setVisible(visible);" why do we need one more call to trigger updateOpaque? ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From serb at openjdk.java.net Sat Sep 4 21:52:47 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 4 Sep 2021 21:52:47 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 19:54:55 GMT, Alexey Ushakov wrote: > Used setOpaque() method to set correct background of platform window Is it possible that the problem is in the performance, what happens if you just add a delay at that place to wait while the metal layer will be updated from the previous calls to updateOpaque? ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From avu at openjdk.java.net Sun Sep 5 11:52:53 2021 From: avu at openjdk.java.net (Alexey Ushakov) Date: Sun, 5 Sep 2021 11:52:53 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 21:22:01 GMT, Phil Race wrote: >> Used setOpaque() method to set correct background of platform window > > src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java line 295: > >> 293: // Set correct background for a window before making it visible >> 294: platformWindow.setOpaque(!isTranslucent()); >> 295: } > > This looks as if it will affect OpenGL as well as Metal. > Do you see the flckering with both pipelines ? > What testing have you done with both of them ? Yes, it affects both pipelines, but flickering was noticed only with Metal. I've tried IDEA on both pipelines and I've run desktop tests only with Metal. I'm going to run desktop ones with OGL too. ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From avu at openjdk.java.net Sun Sep 5 11:57:55 2021 From: avu at openjdk.java.net (Alexey Ushakov) Date: Sun, 5 Sep 2021 11:57:55 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 21:35:32 GMT, Sergey Bylokhov wrote: > Calling "platformWindow.setOpaque(!isTranslucent());" is equvivalent of calling these three methods: > > ``` > setOpaque(getTarget().isOpaque()); > applyShape(Region.getInstance(shape, null)); > peer.setTextured(IS(TEXTURED, styleBits)); > ``` > > All of them are executed before "platformWindow.setVisible(visible);" why do we need one more call to trigger updateOpaque? The flickering is only noticed with some components and adding setOpaque (that sets correct background color inside) definitely helps. I'll check more carefully all the paths. ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From avu at openjdk.java.net Sun Sep 5 12:02:54 2021 From: avu at openjdk.java.net (Alexey Ushakov) Date: Sun, 5 Sep 2021 12:02:54 GMT Subject: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 In-Reply-To: References: Message-ID: On Sat, 4 Sep 2021 21:49:20 GMT, Sergey Bylokhov wrote: > Is it possible that the problem is in the performance, what happens if you just add a delay at that place to wait while the metal layer will be updated from the previous calls to updateOpaque? I'll check it. ------------- PR: https://git.openjdk.java.net/jdk/pull/5373 From github.com+741251+turbanoff at openjdk.java.net Mon Sep 6 09:20:01 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Mon, 6 Sep 2021 09:20:01 GMT Subject: RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop Message-ID: Result of string concatenation is a newly created `String` object. There is no need it wrap it in another `new String` call. Such calls are confusing and produce warnings in IDE. Without them code is easier to read. ------------- Commit messages: - [PATCH] Remove redundant 'new String' calls after concatenation in java.desktop Changes: https://git.openjdk.java.net/jdk/pull/5356/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5356&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273375 Stats: 91 lines in 15 files changed: 8 ins; 2 del; 81 mod Patch: https://git.openjdk.java.net/jdk/pull/5356.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5356/head:pull/5356 PR: https://git.openjdk.java.net/jdk/pull/5356 From jdv at openjdk.java.net Mon Sep 6 09:20:02 2021 From: jdv at openjdk.java.net (Jayathirth D V) Date: Mon, 6 Sep 2021 09:20:02 GMT Subject: RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop In-Reply-To: References: Message-ID: On Fri, 3 Sep 2021 07:53:21 GMT, Andrey Turbanov wrote: > Result of string concatenation is a newly created `String` object. There is no need it wrap it in another `new String` call. > Such calls are confusing and produce warnings in IDE. Without them code is easier to read. Link this PR to bug in JBS. Otherwise change looks fine. ------------- PR: https://git.openjdk.java.net/jdk/pull/5356 From alanb at openjdk.java.net Mon Sep 6 09:42:47 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 6 Sep 2021 09:42:47 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" via an AppContext to support "applet logging isolation". The AppContext class became useless since the plugin and webstart are no longer supported and removed in jdk11. > > This is the request to delete the usage of AppContext in the LogManager and related tests. > > Tested by tier1/tier2/tier3 and jdk_desktop tests. No objection to removing this legacy/unused code but I think it would be useful to useful to have the JBS issue or the PR summary provide a bit more context. As I see it, this is just one piece of the overall cleanup and I assume there are more substantive changes to the java.desktop module coming, is that right? ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From serb at openjdk.java.net Mon Sep 6 20:39:43 2021 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Mon, 6 Sep 2021 20:39:43 GMT Subject: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging In-Reply-To: References: Message-ID: On Mon, 6 Sep 2021 09:39:58 GMT, Alan Bateman wrote: > As I see it, this is just one piece of the overall cleanup and I assume there are more substantive changes to the java.desktop module coming, is that right? Yes, you are right. ------------- PR: https://git.openjdk.java.net/jdk/pull/5326 From mbaesken at openjdk.java.net Tue Sep 7 07:36:53 2021 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 7 Sep 2021 07:36:53 GMT Subject: RFR: JDK-8273387: remove some unreferenced gtk-related functions Message-ID: Please review this small change. Looks like there are a few functions, like gtk2_paint_diamond, that are unreferenced and can be removed. Thanks, Matthias ------------- Commit messages: - JDK-8273387 Changes: https://git.openjdk.java.net/jdk/pull/5384/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5384&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273387 Stats: 63 lines in 2 files changed: 0 ins; 61 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5384.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5384/head:pull/5384 PR: https://git.openjdk.java.net/jdk/pull/5384 From philip.race at oracle.com Wed Sep 15 18:09:08 2021 From: philip.race at oracle.com (Philip Race) Date: Wed, 15 Sep 2021 11:09:08 -0700 Subject: Retiring this awt-dev list on 30th September 2021 In-Reply-To: References: Message-ID: As described below -Phil. -------- Forwarded Message -------- Subject: Retiring 2d, awt, beans, sound and swing mailing lists on 30th September 2021 Date: Wed, 15 Sep 2021 11:05:09 -0700 From: Philip Race To: client-libs-dev at openjdk.java.net Since : 1) The old client groups mailing lists were consolidated into client-libs-dev at openjdk dot java dot net [1], including subscribing all subscribers to the old invividual lists to the new consolidated list, and 2) The skara github tooling has also migrated to that new list and 3) Folks are already using the new list for questions etc Then : I think it is time to plan the retirement of all the old lists : 2d-dev [2], awt-dev [3], beans-dev [4], sound-dev [5], and swing-dev [6] Accordingly I propose that these five old lists become archived and read-only as of 12pm PDT 30th September 2021 and will ask the mail server adminstrators to plan to implement this at that time. I will also forward this information to each of those individual lists. -Phil Race Client Libs Group Lead. [1] https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev [2] https://mail.openjdk.java.net/mailman/listinfo/2d-dev [3] https://mail.openjdk.java.net/mailman/listinfo/awt-dev [4] https://mail.openjdk.java.net/mailman/listinfo/beans-dev [5] https://mail.openjdk.java.net/mailman/listinfo/sound-dev [6] https://mail.openjdk.java.net/mailman/listinfo/swing-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From philip.race at oracle.com Wed Sep 29 04:02:55 2021 From: philip.race at oracle.com (Philip Race) Date: Tue, 28 Sep 2021 21:02:55 -0700 Subject: Retiring this awt-dev list on 30th September 2021 In-Reply-To: References: Message-ID: Reminder. -phil On 9/15/21 11:09 AM, Philip Race wrote: > As described below > > -Phil. > > -------- Forwarded Message -------- > Subject: Retiring 2d, awt, beans, sound and swing mailing lists on > 30th September 2021 > Date: Wed, 15 Sep 2021 11:05:09 -0700 > From: Philip Race > To: client-libs-dev at openjdk.java.net > > > > Since : > 1) The old client groups mailing lists were consolidated into > client-libs-dev at openjdk dot java dot net [1], > including subscribing all subscribers to the old invividual lists to > the new consolidated list, and > 2) The skara github tooling has also migrated to that new list and > 3) Folks are already using the new list for questions etc > > Then : > I think it is time to plan the retirement of all the old lists : > 2d-dev [2], awt-dev [3], beans-dev [4], sound-dev [5], and swing-dev [6] > > Accordingly I propose that these five old lists become archived and > read-only as of 12pm PDT 30th September 2021 > and will ask the mail server adminstrators to plan to implement this > at that time. > > I will also forward this information to each of those individual lists. > > -Phil Race > Client Libs Group Lead. > > [1] https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev > [2] https://mail.openjdk.java.net/mailman/listinfo/2d-dev > [3] https://mail.openjdk.java.net/mailman/listinfo/awt-dev > [4] https://mail.openjdk.java.net/mailman/listinfo/beans-dev > [5] https://mail.openjdk.java.net/mailman/listinfo/sound-dev > [6] https://mail.openjdk.java.net/mailman/listinfo/swing-dev > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: