<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hello, Alexander.<div><br></div><div>The fix looks good to me.</div><div><br></div><div>With best regards. Petr.</div><div><br><div style=""><div>On 12 мая 2014 г., at 19:44, Alexander Zvegintsev <<a href="mailto:alexander.zvegintsev@oracle.com">alexander.zvegintsev@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<div bgcolor="#FFFFFF" text="#000000">
Hello AWT team,<br>
<br>
please review the fix<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/">http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/</a><br>
for the issue <br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8041896">https://bugs.openjdk.java.net/browse/JDK-8041896</a><br>
<br>
This test failure is a regression of the <a href="https://bugs.openjdk.java.net/browse/JDK-7159566" title="The
choice positioned in the top of applet when clicking the choice."><strike>JDK-7159566</strike></a>
fix. We trying to call getLocationOnScreen() on a hidden popup. <br>
We hide it if item count is 0 in AquaComboBoxPopup.show(). <br>
However, native Cocoa apps doesn't show a popup if it is empty at
all, this fix do the same for java.<br>
<br>
With this fix RemoveAllShrinkTest test moved to open.<br>
<pre class="moz-signature" cols="72">--
Thanks,
Alexander.</pre>
</div>
</blockquote></div><br></div></body></html>