<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Sergey,<br>
<br>
I'm fine with it.<br>
<br>
Regards,<br>
Anton.<br>
<br>
On 10.04.2015 18:08, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5527E781.4000209@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hello,<br>
The new version of the fix:<br>
- @deprecated tag was removed<br>
- the message was changed to
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
"UI components are unsupported by: " + toolkit<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8074757/webrev.05">http://cr.openjdk.java.net/~serb/8074757/webrev.05</a><br>
<br>
On 10.04.15 11:52, Anton V. Tarasov wrote:<br>
</div>
<blockquote cite="mid:55278F54.4090002@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 07.04.2015 17:28, Sergey
Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5523E99D.4090804@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 03.04.15 20:14, Phil Race
wrote:<br>
</div>
<blockquote cite="mid:551ECA6A.2010200@oracle.com" type="cite">
It does not need to be deprecated. It can be 'undeprecated'
It was deprecated only because<br>
it was the public Toolkit method that is now gone ..<br>
</blockquote>
Ok, I'll update it.<br>
<blockquote cite="mid:551ECA6A.2010200@oracle.com" type="cite">
So perhaps there's just a small adjustment needed in the
case of where we use createComponent() ??<br>
</blockquote>
It is used in 3 places:<br>
- Indirectly in Canvas and Panel where our headless toolkits
creates NullComponentPeer instead of the native peer. So the
question is this is implementation detail of our headless
toolkit or all such toolkits should use the same things.<br>
- In Component class I can reuse NullComponentPeer, but it is
unclear how we survive this later when external tollkit is in
use.<br>
<br>
If nobody objects then I suggest for now to use this new error
as an assertion to find possible usage of these methods,
instead of silent usage of some empty stub, and fail sometime
later with unclear reason.<br>
</blockquote>
<br>
Hi Sergey,<br>
<br>
I don't object throwing AWTError. However, if we still claim to
support external toolkits at least in headless env, then doesn't
it make sense to clarify the error message?<br>
<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="new" style="color: blue; font-weight: normal;">+ throw new AWTError("Unsupported toolkit: " + toolkit);
</span></pre>
to something like "Unsupported headful toolkit" or "Only
headless custom toolkits are supported"?<br>
<br>
Thanks,<br>
Anton.<br>
<br>
<br>
<blockquote cite="mid:5523E99D.4090804@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<blockquote cite="mid:551ECA6A.2010200@oracle.com" type="cite">
<br>
-phil.<br>
<blockquote cite="mid:551ECA99.8010406@oracle.com"
type="cite">
<blockquote cite="mid:551EC70E.6080201@oracle.com"
type="cite"> <br>
-phil. <br>
<br>
On 04/02/2015 08:15 AM, Sergey Bylokhov wrote: <br>
<blockquote type="cite">Hello. <br>
Please review the fix for jdk 9. <br>
There are a number of public methods in the
java.awt.Toolkit class, which reference the
unsupported java.awt.dnd.peer and java.awt.peer
interfaces. <br>
<br>
There is a decision to remove these references as
described: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/awt-dev/2015-February/008924.html">http://mail.openjdk.java.net/pipermail/awt-dev/2015-February/008924.html</a>
<br>
Changes description: <br>
- All such methods were moved from Toolkit.java to
the ComponentFactory.java. Note that all our toolkits
implement ComponentFactory interface. <br>
- HToolkit, HeadlessToolkit, SunToolkit were cleared
because they have the same implementation of these
methods as in ComponentFactory. <br>
- The questionable moment is that I throw an AWTError
in a some places if a default toolkit not implements
ComponentFactory interface. <br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8074757">https://bugs.openjdk.java.net/browse/JDK-8074757</a>
<br>
Webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8074757/webrev.04">http://cr.openjdk.java.net/~serb/8074757/webrev.04</a>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</body>
</html>