[code-reflection] RFR: More systematic binary op tests
Hannes Greule
hgreule at openjdk.org
Mon Apr 8 19:43:26 UTC 2024
On Mon, 18 Mar 2024 22:44:29 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> That's an interesting use of `OpDefinition` i never really anticipated, but it does lend itself to more general production of operations. Here is a more concise way (when the lambda does not capture):
Oh, that's what I was looking for, but I somehow missed it. My creation was basically just the first "this works" way I found.
----
I added a second variant, where we use `@CodeReflection`-annotated methods as a base and transform them for different types. This probably makes the distinction between model and test input clearer. But for now, I'm not 100% happy with either solution.
----
Btw, I noticed that `FuncOp#resultType()` always `JavaType.VOID`. Is that intended? (At least I was surprised)
-------------
PR Comment: https://git.openjdk.org/babylon/pull/40#issuecomment-2007952265
More information about the babylon-dev
mailing list