[code-reflection] RFR: Adding String Concatenation to Code Model [v2]

Paul Sandoz psandoz at openjdk.org
Tue Apr 9 20:08:08 UTC 2024


On Tue, 9 Apr 2024 18:21:39 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> Adding String concatenation to the code model and interpreter.
>
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates and cleanup

test/jdk/java/lang/reflect/code/TestConcat.java line 46:

> 44:     static final String TESTSTR = "TESTING STRING";
> 45: 
> 46:     static final int TESTINT = 42;

Not used, code is commented out. Is this test useful? I suppose it tests constants, which i believe the compiler will concatenate.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/47#discussion_r1558223214


More information about the babylon-dev mailing list