[code-reflection] RFR: Erase receiver type before calling Gen::binaryQualifier

[Paul Sandoz]

On Fri, 12 Apr 2024 12:01:35 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> I found an issue where `Gen::binaryQualifier` was called on a non-denotable reveiver type. This led to a crash, as `binaryQualifier` ended up creating a new symbol whose owner was the non-denotable receiver and, at least for some symbols, we check in the constructor that the owner can't be a type-variable.
> 
> The solution is to make sure that the receiver type (`site`) passed to `binaryQualifier` is always erased, which is also the assumption `Gen` makes (obviously).

Marked as reviewed by psandoz (Lead).

-------------

PR Review: https://git.openjdk.org/babylon/pull/50#pullrequestreview-1998336965