[code-reflection] RFR: InnerClassLambdaMetafactory fix of hidden classes handling [v4]

Adam Sotona asotona at openjdk.org
Thu Apr 18 15:33:42 UTC 2024


On Thu, 18 Apr 2024 15:27:33 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'code-reflection' into generator-round-3
>>  - 8330467: NoClassDefFoundError when lambda is in a hidden class
>>    
>>    Reviewed-by: psandoz, mchung
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>>    #	test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java
>>  - applied suggested changes
>>  - fix of the non-reflective args load only
>>  - fixed InnerClassLambdaMetafactory for hidden classes
>
> test/jdk/java/lang/invoke/defineHiddenClass/src/Lambda.java line 28:
> 
>> 26: public class Lambda implements HiddenTest {
>> 27:      public void test() {
>> 28:          Function<Object, String> f = o -> o.toString();
> 
> Revert this change?

Yes, I missed it.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/52#discussion_r1570979868


More information about the babylon-dev mailing list