[code-reflection] RFR: Add support for more types [v2]

[Paul Sandoz]

On Fri, 26 Apr 2024 10:18:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> I can take a look
>
> Uploaded a new iteration with this simplification (which looks much nicer than what I had):
> 
> 8ad6110bdb3c099b1421a04272c56685dd551f95
> 
> Note that if we wanted a truly general "quoting" mechanism we'd need both a prefix and a suffix token. Otherwise one can only use quotes if there's some nested type-definition with `<>`. Your idea of using just strings (e.g. surrounded with `"`) seems a powerful one (and more robust in the long run), because it would make the desc parsing logic a lot less opinionated (e.g. we wouldn't even need to special case qualified identifiers).

That's much simpler. We can iterate further afterwards if need be. I believe you can now replace `identifier.contains("::")` with `identifier.startsWith("#")`?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/51#discussion_r1581247500