[code-reflection] RFR: Fix test failure after PR/51
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Apr 26 17:54:23 UTC 2024
A test is failing after my push of https://git.openjdk.org/babylon/pull/51
The problem is that I've tweaked the logic for parsing type-variables, so that now we check for a starting `#` in the core type factory.
But the `#` char is not copied into the identifier, hence the issue.
Unfortunately sometimes tests seem to pass even though they are run after a `make images`. The problem is that after changes in the `j.l.reflect.code` packages, only `java.base` is rebuilt, and the `jdk.compiler` copy is not. This means that, unless one does `make images` all the time, some tests might pass (or fail) spuriously. We might need to look at the build again.
-------------
Commit messages:
- Initial push
Changes: https://git.openjdk.org/babylon/pull/63/files
Webrev: https://webrevs.openjdk.org/?repo=babylon&pr=63&range=00
Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/babylon/pull/63.diff
Fetch: git fetch https://git.openjdk.org/babylon.git pull/63/head:pull/63
PR: https://git.openjdk.org/babylon/pull/63
More information about the babylon-dev
mailing list