[code-reflection] Integrated: Fix test failure after PR/51
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Apr 26 18:01:15 UTC 2024
On Fri, 26 Apr 2024 17:46:53 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> A test is failing after my push of https://git.openjdk.org/babylon/pull/51
>
> The problem is that I've tweaked the logic for parsing type-variables, so that now we check for a starting `#` in the core type factory.
> But the `#` char is not copied into the identifier, hence the issue.
>
> Unfortunately sometimes tests seem to pass even though they are run after a `make images`. The problem is that after changes in the `j.l.reflect.code` packages, only `java.base` is rebuilt, and the `jdk.compiler` copy is not. This means that, unless one does `make images` all the time, some tests might pass (or fail) spuriously. We might need to look at the build again.
This pull request has now been integrated.
Changeset: 799abb7f
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/babylon/commit/799abb7f548d6e21d40bda11878b2a9f072f2c2d
Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod
Fix test failure after PR/51
Reviewed-by: psandoz
-------------
PR: https://git.openjdk.org/babylon/pull/63
More information about the babylon-dev
mailing list