[code-reflection] RFR: Make jdk.compiler build depend on code model API in java.base [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Apr 29 16:50:31 UTC 2024
> This PR fixes a nasty build issue where the jdk.compiler copy of the code model classes were not re-generated during an incremental build after a code model API or implementation change. This resulted in weird situations where, after a breaking change and an incremental build, compiler tests would seem fine, because they would really run against the unmodified copy of the code model classes (that were not regenerated after the breaking change).
>
> The fix is to add the code model java files under `src/java.base/share/classes/java/lang/reflect/code` as dependencies of the `GENSTUBS` target for the `jdk.compiler` module.
>
> To test, I've tried to make `CoreOps::conv` to throw an exception unconditionally, then rebuild incrementally and run the compiler tests, to check that they were indeed seeing the new exception.
Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
Address review comments
-------------
Changes:
- all: https://git.openjdk.org/babylon/pull/65/files
- new: https://git.openjdk.org/babylon/pull/65/files/cf80a80e..e08ac111
Webrevs:
- full: https://webrevs.openjdk.org/?repo=babylon&pr=65&range=01
- incr: https://webrevs.openjdk.org/?repo=babylon&pr=65&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
Patch: https://git.openjdk.org/babylon/pull/65.diff
Fetch: git fetch https://git.openjdk.org/babylon.git pull/65/head:pull/65
PR: https://git.openjdk.org/babylon/pull/65
More information about the babylon-dev
mailing list