[code-reflection] RFR: Bytecode round 9 [v30]

Adam Sotona asotona at openjdk.org
Fri Aug 9 08:28:14 UTC 2024


> Bytecode round 9 contains following improvements:
> - `String` (and non-`String`) concats are lifted to `CoreOp.ConcatOp`
> - `LocalsTypeMapper` is fixed to use instruction index as a key (instead of the instruction identity)
> - `LocalsTypeMapper` newly calculates types of uninitialized stack map frame entries and provides that info to `BytecodeLift`
> - `BytecodeLift` is fixed to handle deep stacks correctly while branching + tests added
> - Oboslete `BytecodeGenerator::conversion` method is replaced by direct call of `CodeBuilder::conversion`
> - LocalTypeMapper performs iterative correction of int stack map frame entries to support byte, boolean, short and char types
> 
> `TestSmallCorpus` is not experiencing any first-lift exceptions after the above changes, however we cannot yet say that all the lifted models are correct.
> 
> Please review.
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 39 additional commits since the last revision:

 - Merge remote-tracking branch 'babylon/code-reflection' into bytecode-round-9
 - fixed identification of the right target block in BytecodeLift
 - included verification into TestSmallCorpus
 - explicit cast of method return type to InvokeOp return type in BytecodeGenerator
 - fixed generation of BASTORE, SASTORE and CASTORE
 - fixed lifting of complex nested exception regions
 - fixed generation of multi-catch exception regions
 - BytecodeLKift fixed insertion of exception region exits before handler blocks in nested try/catch
   and de-duplicated exception regions
 - fixed lifting of CONDY with vararg BSM
 - Removing catch blocks from dominance frontier in SlotSSA
 - ... and 29 more: https://git.openjdk.org/babylon/compare/8c1b6ef2...129a80de

-------------

Changes:
  - all: https://git.openjdk.org/babylon/pull/192/files
  - new: https://git.openjdk.org/babylon/pull/192/files/17fbfc56..129a80de

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=babylon&pr=192&range=29
 - incr: https://webrevs.openjdk.org/?repo=babylon&pr=192&range=28-29

  Stats: 4849 lines in 54 files changed: 2688 ins; 1934 del; 227 mod
  Patch: https://git.openjdk.org/babylon/pull/192.diff
  Fetch: git fetch https://git.openjdk.org/babylon.git pull/192/head:pull/192

PR: https://git.openjdk.org/babylon/pull/192


More information about the babylon-dev mailing list