[code-reflection] RFR: Bytecode round 9 [v32]

Adam Sotona asotona at openjdk.org
Mon Aug 12 09:16:47 UTC 2024


On Fri, 9 Aug 2024 23:14:05 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated TestSmallCorpus
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 950:
> 
>> 948:         return uses.size() > 1
>> 949:             || uses.size() == 1 && uses.iterator().next().op().operands().stream().filter(o -> o == res).count() > 1
>> 950:             || inBlockArgs(res);
> 
> Uses will return a use if the value used as an operand or as a successor argument, but as you found out it will not differentiate between single and multiple uses of the same value for the same operation, which in theory could be across operands or successor arguments.

Will fix it, thanks.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/192#discussion_r1713410706


More information about the babylon-dev mailing list