[code-reflection] RFR: 8337158: Modeling and lowering of switch statement [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Aug 15 16:35:12 UTC 2024


On Fri, 9 Aug 2024 22:46:17 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test switch statement model
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ReflectMethods.java line 72:
> 
>> 70: import static jdk.internal.java.lang.reflect.code.op.CoreOp._throw;
>> 71: import static jdk.internal.java.lang.reflect.code.type.FunctionType.functionType;
>> 72: import static jdk.internal.java.lang.reflect.code.type.JavaType.type;
> 
> Can you revert these? AFAICT they are inconsistently used, plus non-related changes make it harder to review.

Agreed - I'll wait to review until these spurious changes are reverted - hard to see the forest for the trees in here :-)

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/211#discussion_r1718667222


More information about the babylon-dev mailing list