[code-reflection] RFR: BytecodeLift directly calculating local variables + related BytecodeGenerator fixes [v4]

[Adam Sotona]

On Fri, 23 Aug 2024 16:31:52 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   roundtrip stabilization
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeLift.java line 235:
> 
>> 233:                 case ITEM_DOUBLE -> params.add(JavaType.DOUBLE);
>> 234:                 case ITEM_LONG -> params.add(JavaType.LONG);
>> 235:                 case ITEM_NULL -> params.add(JavaType.wildcard());
> 
> That's a curious change, can you explain why you did that?

I did this purely for debugging purposes. It is hard to differentiate if a variable has J_L_OBJECT type intentionally or as a result of a bug in the merge process of the lift.
I can revert it if needed.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/218#discussion_r1730872527