[code-reflection] RFR: Exception regions fix [v6]

Paul Sandoz psandoz at openjdk.org
Thu Feb 1 22:13:14 UTC 2024


On Thu, 1 Feb 2024 07:53:16 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 359:
>> 
>>> 357:                 this.block = block;
>>> 358:                 this.activeRegions = activeRegions;
>>> 359:                 int index = blocks.indexOf(block);
>> 
>> We should be able to use `block.index()`, however that is not fully working as intended right now and needs to be fixed (i.e., this invariant should hold `block.index() == blocks.indexOf(block)`, but currently does not)
>
> Yes, that would avoid confusion and save some CPU.

See #14

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/12#discussion_r1475217015


More information about the babylon-dev mailing list