[code-reflection] RFR: Exception regions fix [v6]

Adam Sotona asotona at openjdk.org
Fri Feb 2 08:10:32 UTC 2024


On Thu, 1 Feb 2024 18:51:00 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added TestBranchCompactor
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BranchCompactor.java line 48:
> 
>> 46:     private BranchInstruction firstBranch, secondBranch;
>> 47:     private final List<PseudoInstruction> pseudoBuffer1 = new ArrayList<>(),
>> 48:                                           pseudoBuffer2 = new ArrayList<>();
> 
> Can these move respectively to fields on the anonymous classes for instances of `INIT_STATE` and `LOOKING_FOR_SHORT_JUMP`? (Style-wise the names should ideally be in camel case because they are not static)

Yes, I'll fix it, thanks.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/12#discussion_r1475702231


More information about the babylon-dev mailing list