[code-reflection] RFR: Exception regions fix [v9]

Adam Sotona asotona at openjdk.org
Fri Feb 2 22:00:31 UTC 2024


On Fri, 2 Feb 2024 16:13:20 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   BranchCompactor cleanup
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BranchCompactor.java line 60:
> 
>> 58:             switch (coe) {
>> 59:                 case LabelTarget lt -> {
>> 60:                     if (branch.target() == lt.label()) {
> 
> Since `LabelTarget` is also a `PsuedoInstruction` you could make this case be:
> 
> case LabelTarget when branch.target() == lt.label() -> { ... }
> 
> Thereby collapsing the if/else. Up to you.

Fixed, thanks.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/12#discussion_r1476784627


More information about the babylon-dev mailing list