[code-reflection] RFR: Remove bytecode dialect [v8]
Paul Sandoz
psandoz at openjdk.org
Wed Feb 7 19:21:03 UTC 2024
On Wed, 7 Feb 2024 18:59:30 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> This patch re-implements `BytecodeLift` to lift from bytecode directly to the core dialect
>> and removes `BytecodeInstructionOps` with the bytecode dialect.
>>
>> Implementation is complete up to the point of passing all current tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>
> lifting try catch blocks + test
BTW this case worked before but now fails with latest changes (not currently part of the tests):
static int f(int a, int b, int n) {
return (n < 10) ? a : b;
}
But i don't know if it worked before you modified to do a single pass. The issue is the block parameter modeling the result of the conditional expression is not used as the operand to the return operation. So there is something up with what's pushed onto the stack.
-------------
PR Comment: https://git.openjdk.org/babylon/pull/16#issuecomment-1932710555
More information about the babylon-dev
mailing list