[code-reflection] RFR: Review FieldLoadOp [v2]

Mourad Abbay mabbay at openjdk.org
Tue Feb 13 03:16:15 UTC 2024


On Tue, 13 Feb 2024 03:13:04 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Make sure FieldLoadOp is consistent with other reflective operations.
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete unnecessary comment

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ReflectMethods.java line 833:

> 831: 
> 832:                     Op.Result lhsOpValue;
> 833:                     TypeDesc resultType = typeToDesc(sym.type); // why not sym.type

This comment can be deleted. Before, I was getting the type using assign.selected.type, now sym.type seems to give the same result.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/19#discussion_r1487100827


More information about the babylon-dev mailing list