[code-reflection] RFR: Add and/or/xor operations to code model

Paul Sandoz psandoz at openjdk.org
Wed Feb 14 17:03:07 UTC 2024


On Tue, 13 Feb 2024 16:38:15 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

> Adds Ops for `&`, `|`, an `^`. I added some very basic tests for the interpreter and the bytecode.
> 
> I also added other missing methds to `InvokableLeafOps`, namely `mod` for floating point types and eq/neq for boolean.
> 
> I also noticed that `AddOp` currently models String concatenation, and the Interpreter also has a method for it, but that doesn't work because the method type is erased to Object, so that might require some more work in future.
> 
> There are also shifts and some unary operations missing for now, I can work on them in future if you want.

Yes, i think it makes sense to consolidate such tests in a better pattern, which may be applicable more broadly.

If you are going to parameterize the test i will not object, and will actively encourage, a switch to junit 5 (and we can slowly convert over the other tests).

-------------

PR Comment: https://git.openjdk.org/babylon/pull/21#issuecomment-1944238842


More information about the babylon-dev mailing list