[code-reflection] RFR: Structured type definition [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Feb 15 09:58:07 UTC 2024


On Thu, 15 Feb 2024 00:37:19 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Replace the currently implementation of `TypeDefinition` with a more general tree structure, which is the boundary between the runtime and serialized form.
>> 
>> This should help when/if we devise a richer modeling of Java types
>
> Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Method rename.

Marked as reviewed by mcimadamore (Reviewer).

cr-examples/triton/src/main/java/oracle/code/triton/TensorType.java line 88:

> 86: 
> 87:     @Override
> 88:     public String toString() {

Would it make sense for this to be a default method in the TypeElement interface? (probably also related to `equals/hashCode`

-------------

PR Review: https://git.openjdk.org/babylon/pull/23#pullrequestreview-1882310732
PR Review Comment: https://git.openjdk.org/babylon/pull/23#discussion_r1490733260


More information about the babylon-dev mailing list