[code-reflection] RFR: Separate TypeElement from Type.

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Feb 26 21:38:51 UTC 2024


On Mon, 26 Feb 2024 20:52:41 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> `TritonType` currently extends from `TypeElement` and `Type` to allow for the convenient composition of a code model type (symbolical description of a type) and a runtime type. This is confusing, and is mixing layers. `TritonType` should only extended from `TypeElement` and same for any arguments of.

cr-examples/triton/src/test/java/oracle/code/triton/TestAddKernel.java line 96:

> 94:     @Test
> 95:     public void test(TritonTestData t) {
> 96:         List<TypeElement> argTypes = List.of(

I think this is still syntactically pleasing, but conceptually more straightforward. Good job!

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/29#discussion_r1503330410


More information about the babylon-dev mailing list