[code-reflection] RFR: throw instead returning when erasing checked to unchecked exception [v2]

[Hannes Greule]

> As discussed in https://mail.openjdk.org/pipermail/babylon-dev/2024-January/000006.html, I change the `erase` method to `eraseAndThrow` and added a test as suggested. I ensured that the test fails without my change and does not fail with it.

Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:

  address comments

-------------

Changes:
  - all: https://git.openjdk.org/babylon/pull/2/files
  - new: https://git.openjdk.org/babylon/pull/2/files/50fdca78..3bb6812f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=babylon&pr=2&range=01
 - incr: https://webrevs.openjdk.org/?repo=babylon&pr=2&range=00-01

  Stats: 35 lines in 1 file changed: 15 ins; 9 del; 11 mod
  Patch: https://git.openjdk.org/babylon/pull/2.diff
  Fetch: git fetch https://git.openjdk.org/babylon.git pull/2/head:pull/2

PR: https://git.openjdk.org/babylon/pull/2