[code-reflection] RFR: Support array type constants in code model [v2]

Hannes Greule hgreule at openjdk.org
Mon Jan 22 13:40:06 UTC 2024


On Fri, 19 Jan 2024 17:34:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test case for compiler IR output
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ReflectMethods.java line 907:
> 
>> 905:         @Override
>> 906:         public void visitTypeArray(JCTree.JCArrayTypeTree tree) {
>> 907:             result = null; // MyType[].class is handled in visitSelect just as MyType.class
> 
> Looks good - can you add a test case in `test/langtools/tools/javac/reflect/ConstantTest` (the last test case in this test has an example of class literals). Just to make sure the IR comes out ok, and that we don't have regression when we change the compiler code ;-)

Good suggestion, done.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/5#discussion_r1461873042


More information about the babylon-dev mailing list