[code-reflection] RFR: Support array type constants in code model [v2]
Hannes Greule
hgreule at openjdk.org
Mon Jan 22 17:04:20 UTC 2024
On Mon, 22 Jan 2024 16:39:03 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add test case for compiler IR output
>
> src/java.base/share/classes/java/lang/reflect/code/op/CoreOps.java line 1082:
>
>> 1080: if (dimensions > 0) {
>> 1081: desc = desc.arrayType(dimensions);
>> 1082: }
>
> Instead we can just use `TypeDesc.ofString`.
>
> Until recently we could not parse descriptors in classes in`java.base` that are copied and repackaged in `jdk.compiler` (we are trying to limit the amount of code that is copied). With some refactoring this is now possible for such classes in `java.base` and when copied it is made partial.
Ah, that's exactly what I was looking for, thanks!
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/5#discussion_r1462153120
More information about the babylon-dev
mailing list