[code-reflection] RFR: Support array type constants in code model [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jan 22 18:15:57 UTC 2024


On Mon, 22 Jan 2024 18:13:05 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use TypeDesc.ofString instead of custom parsing
>
> test/langtools/tools/javac/reflect/ConstantsTest.java line 219:
> 
>> 217:     }
>> 218: 
>> 219:     @IR("""
> 
> Thanks - the test looks good. Is it worth it to maybe also try `String[][]` and `String[][][]` ?

And, also a primitive array?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/5#discussion_r1462234018


More information about the babylon-dev mailing list