[code-reflection] RFR: Support array type constants in code model [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jan 22 21:46:52 UTC 2024


On Mon, 22 Jan 2024 19:21:07 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> Previously, expressions like `String[].class` weren't supported in the code model.
>> 
>> As types are embedded by their fully qualified names (e.g. `java.lang.String[]`), we also have to parse that representation again. I didn't find an existing method to do so, so I wrote it myself. Please let me know if there's a better approach.
>> 
>> I also adapted the test from `TestArrayCreation.java`, using different kinds of array types.
>
> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add more compiler IR output tests

Marked as reviewed by mcimadamore (Reviewer).

-------------

PR Review: https://git.openjdk.org/babylon/pull/5#pullrequestreview-1837429282


More information about the babylon-dev mailing list