[code-reflection] RFR: 8324556: Not copy result-type when copying an op [v2]

Paul Sandoz psandoz at openjdk.org
Thu Jan 25 17:48:56 UTC 2024


On Thu, 25 Jan 2024 17:45:06 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> 8324556: Not copy result-type when copying an op
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply Paul's suggestions

src/java.base/share/classes/java/lang/reflect/code/op/ExtendedOps.java line 742:

> 740:             // I kept this for now to not affect code in ReflectMethods,
> 741:             // but I think resultType can be computed using: bodies.get(1).yieldType();
> 742:             this.type = type;

Do you intend to follow up on this comment?
Recommend that you prefix with `@@@` to indicate its a possible future action to update the code.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/6#discussion_r1466729125


More information about the babylon-dev mailing list